Skip to content

ARROW-17965: [C++] ExecBatch support for ChunkedArray values#14348

Merged
lidavidm merged 5 commits into
apache:masterfrom
rtpsw:ARROW-17965
Oct 15, 2022
Merged

ARROW-17965: [C++] ExecBatch support for ChunkedArray values#14348
lidavidm merged 5 commits into
apache:masterfrom
rtpsw:ARROW-17965

Conversation

@rtpsw

@rtpsw rtpsw commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Oct 7, 2022

Copy link
Copy Markdown

Comment thread cpp/src/arrow/compute/exec.cc Outdated
Comment thread cpp/src/arrow/compute/exec.cc Outdated
Comment thread cpp/src/arrow/compute/exec.cc Outdated
@rtpsw

rtpsw commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

@kou, what remains for this PR to go through?

@kou

kou commented Oct 14, 2022

Copy link
Copy Markdown
Member

@lidavidm What do you think about this approach?

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Needs to be rebased, though.)

@rtpsw

rtpsw commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

@lidavidm, it would be easier for me to resolve-conflict directly. OK with you?

@lidavidm

Copy link
Copy Markdown
Member

Oh sure, as long as the conflict is solved

@lidavidm lidavidm merged commit d809c28 into apache:master Oct 15, 2022
@rtpsw rtpsw deleted the ARROW-17965 branch October 15, 2022 15:32
@ursabot

ursabot commented Oct 17, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 289e0c9 and contender = d809c28. d809c28 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.96% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d809c285 ec2-t3-xlarge-us-east-2
[Failed] d809c285 test-mac-arm
[Finished] d809c285 ursa-i9-9960x
[Finished] d809c285 ursa-thinkcentre-m75q
[Finished] 289e0c92 ec2-t3-xlarge-us-east-2
[Failed] 289e0c92 test-mac-arm
[Finished] 289e0c92 ursa-i9-9960x
[Finished] 289e0c92 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Oct 17, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants